Skip to content

Conversation

@kunxian-xia
Copy link
Collaborator

@kunxian-xia kunxian-xia commented Dec 31, 2025

Summary

We want to upgrade the current toolchain to a new one (e.g. nightly-2025-11-20).

However, the recent nightly toolchains already include this PR to introduce a breaking change s.t. the target-pointer-width in ceno_rt/riscv32im-ceno-zkvm-elf.json is integer rather than string.

Additional changes

With nightly-2025-11-20, the feature panic_immediate_abort is now a real panic strategy. Therefore we have to make changes in the script for cross building rv32im ELF.

"target-c-int-width": 32,
"target-endian": "little",
"target-pointer-width": "32"
"target-pointer-width": 32
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an integer rather than a string like target-c-int-width.

]
build-std-features = [
"compiler-builtins-mem",
"panic_immediate_abort",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panic_immediate_abort is default in nightly-2025-11-20.

"build-std=alloc,core,compiler_builtins,std,panic_abort,proc_macro",
"-Z",
"build-std-features=compiler-builtins-mem,panic_immediate_abort,default",
"build-std-features=compiler-builtins-mem,default",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panic_immediate_abort is default in nightly-2025-11-20.

@kunxian-xia kunxian-xia requested a review from hero78119 January 19, 2026 06:06
@kunxian-xia kunxian-xia linked an issue Jan 19, 2026 that may be closed by this pull request
@kunxian-xia kunxian-xia changed the title chore: upgrade to rust-toolchain to nightly-2025-11-20 chore: upgrade rust-toolchain to nightly-2025-11-20 Jan 19, 2026
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kunxian-xia kunxian-xia enabled auto-merge January 19, 2026 07:19
@kunxian-xia kunxian-xia added this pull request to the merge queue Jan 19, 2026
Merged via the queue into master with commit 101a61c Jan 19, 2026
4 checks passed
@kunxian-xia kunxian-xia deleted the chore/rust-toolchain branch January 19, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade rust toolchain

3 participants