-
Notifications
You must be signed in to change notification settings - Fork 40
chore: upgrade rust-toolchain to nightly-2025-11-20
#1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "target-c-int-width": 32, | ||
| "target-endian": "little", | ||
| "target-pointer-width": "32" | ||
| "target-pointer-width": 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an integer rather than a string like target-c-int-width.
| ] | ||
| build-std-features = [ | ||
| "compiler-builtins-mem", | ||
| "panic_immediate_abort", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
panic_immediate_abort is default in nightly-2025-11-20.
| "build-std=alloc,core,compiler_builtins,std,panic_abort,proc_macro", | ||
| "-Z", | ||
| "build-std-features=compiler-builtins-mem,panic_immediate_abort,default", | ||
| "build-std-features=compiler-builtins-mem,default", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
panic_immediate_abort is default in nightly-2025-11-20.
nightly-2025-11-20nightly-2025-11-20
hero78119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
We want to upgrade the current toolchain to a new one (e.g.
nightly-2025-11-20).However, the recent nightly toolchains already include this PR to introduce a breaking change s.t. the
target-pointer-widthinceno_rt/riscv32im-ceno-zkvm-elf.jsonis integer rather than string.Additional changes
With
nightly-2025-11-20, the featurepanic_immediate_abortis now a real panic strategy. Therefore we have to make changes in the script for cross buildingrv32imELF.